Build Java Sample App with different language versions #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
java-sample-app-version
branch
from
84ee952 to
20b0bf6
Compare
harrryr
force-pushed
the
java-sample-app-version
branch
from
6e21b2d to
96dabc8
Compare
harrryr
force-pushed
the
java-sample-app-version
branch
from
31ad72f to
93179a1
Compare
harrryr
force-pushed
the
java-sample-app-version
branch
from
8161346 to
416fec6
Compare
harrryr
force-pushed
the
java-sample-app-version
branch
from
9e679bb to
971fed6
Compare
majanjua-amzn
approved these changes
Sep 26, 2024
harrryr
added a commit
that referenced
this pull request
Sep 27, 2024
*Issue description:* Follow up on #247 Add input option for Java EC2 to choose language version *Rollback procedure:* Revert *Test Run* https://github.com/harrryr/aws-application-signals-test-framework/actions/runs/11043127523 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
In order to meet our requirement of ADOT java supporting all java versions 8+, we are planning on testing ADOT Java on the currently available Java versions before release. The test coverage will include Java 8, 11, 17, 21, 22. This PR will aim to build the Java sample apps on different language versions, and once we validate that the new .jar/images are available, we will merge another PR to make the canaries use the new changes
Description of changes:
Build Sample App For Java 8
Our current sample app is built on Java 11, however, some of the libraries that are used to make http calls are not available in Java 8. Built another sample app for Java 8 that uses older libraries.
Upgrade Gradle to 8.10
We use Gradle 8.5 to built our sample app, which doesn't support Java 21+. Upgrading gradle to the latest version 8.10.
Add plugin to use Kotlin 2.0
Gradle 8.10 uses Kotlin 1.x.x, however, Java 22 is supported by Kotlin 2.0. Added plugin in gradle.setting.ts to use the latest Kotlin version.
Refactor java sample app workflows
Updated the workflow files to use the latest secrets for AWS credentials and ECR ARN
Add jobs to build other language versions
Currently, we build Java 11 sample app and deploy to all regions. The other language versions are only required in us-east-1 since it will be used by main-build.yml in ADOT Java repo. Therefore, we made two new jobs in the workflow files to build and deploy new sample apps to us-east-1 only.
Rollback procedure:
Doesn't affect existing image which uses :latest tag. This PR should not affect any existing workflows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.